Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApiCompat] Update Mono.Android ApiCompat reference assembly to current. #8596

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Dec 15, 2023

Update our ApiCompat "baseline" to what we shipped in .NET 8. This means we can delete all current "acceptable breakages". Additionally, we can delete all the acceptable-breakages-v*.0.txt files because they were only used for Classic.

Remove usage of cil-strip.exe from the target to create the baseline .zip, as we no longer provision the Mono bundle which contained it. By default, we produce a .NET ref version of Mono.Android.dll that we can include instead, which already has had CIL stripped from it.

Also update our PublicAPIAnalyzers API-34 profile from PublicAPI.Unshipped.txt -> PublicAPI.Shipped.txt now that we've shipped.

@jpobst jpobst marked this pull request as ready for review December 21, 2023 18:48
@jonpryor
Copy link
Member

jonpryor commented Jan 11, 2024

@jpobst: should this also "rename" or merge src/Mono.Android/PublicAPI/API-34/PublicAPI.Unshipped.txt to src/Mono.Android/PublicAPI/API-34/PublicAPI.Shipped.txt? See also 76ab8b2.

@jonpryor jonpryor merged commit 87341cc into main Jan 12, 2024
47 checks passed
@jonpryor jonpryor deleted the update-api-compat-ref branch January 12, 2024 18:32
grendello added a commit that referenced this pull request Jan 16, 2024
* main:
  [api-compatibility] Update `Mono.Android` information for API-34 (#8596)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants